Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IterableEntityIdPager #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add IterableEntityIdPager #239

wants to merge 1 commit into from

Conversation

lucaswerkmeister
Copy link
Member

This can be used to page through an iterable of entity IDs without having to load it into memory all at once, as an alternative to:

new InMemoryEntityIdPager( ...$iterable )

Motivated by Wikibase change Ifc03865254.

@lucaswerkmeister lucaswerkmeister requested a review from tarrow April 7, 2020 10:58
@lucaswerkmeister
Copy link
Member Author

lucaswerkmeister commented Apr 7, 2020 •
edited
Loading

(github won’t let me set the “needs changes” flag on my own change but please don’t merge right now)

edit: done

@lucaswerkmeister
Add IterableEntityIdPager
7dcf2a9 
This can be used to page through an iterable of entity IDs without
having to load it into memory all at once, as an alternative to:

    new InMemoryEntityIdPager( ...$iterable )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariushoch mariushoch mariushoch approved these changes

@tarrow tarrow Awaiting requested review from tarrow

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaswerkmeister @mariushoch